HappenLee commented on code in PR #13355:
URL: https://github.com/apache/doris/pull/13355#discussion_r996702548
##########
be/src/vec/columns/column_string.cpp:
##########
@@ -444,6 +445,7 @@ void ColumnString::resize(size_t n) {
auto origin_size = size();
if (origin_size > n) {
offsets.resize(n);
+ chars.resize(offsets.back());
Review Comment:
offsets.back() may contain value do not init? so maybe here may cause mem
problem here
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -907,6 +907,10 @@ void SegmentIterator::_init_current_block(
if (_is_pred_column[cid] ||
i >= block->columns()) { //todo(wb) maybe we can release it after
output block
current_columns[cid]->clear();
+ if (i < block->columns()) {
+ block->get_by_position(i).column->assume_mutable()->reserve(
Review Comment:
this code seems should out of the `if else` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
