gavinchou commented on code in PR #57478:
URL: https://github.com/apache/doris/pull/57478#discussion_r2476502152
##########
cloud/src/resource-manager/resource_manager.cpp:
##########
@@ -1413,16 +1413,27 @@ std::pair<MetaServiceCode, std::string>
ResourceManager::refresh_instance(
void ResourceManager::refresh_instance(const std::string& instance_id,
const InstanceInfoPB& instance) {
+ bool is_succeed_instance = instance.has_original_instance_id();
+ std::string source_instance_id = is_succeed_instance ?
instance.source_instance_id() : "";
+
std::lock_guard l(mtx_);
for (auto i = node_info_.begin(); i != node_info_.end();) {
- if (i->second.instance_id != instance_id) {
+ // erase all nodes belong to this instance_id
Review Comment:
typo? "belongs to" -> "not belongs"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
