csun5285 commented on code in PR #56502:
URL: https://github.com/apache/doris/pull/56502#discussion_r2485438564
##########
be/src/olap/rowset/segment_v2/variant/sparse_column_merge_iterator.cpp:
##########
@@ -126,7 +126,8 @@ void
SparseColumnMergeIterator::_merge_to(vectorized::MutableColumnPtr& dst) {
for (size_t row = 0; row != _sparse_column_cache->sparse_column->size();
++row) {
// Use separate index to iterate over sorted
sorted_src_subcolumn_for_sparse_column.
size_t sorted_src_subcolumn_for_sparse_column_idx = 0;
- size_t sorted_src_subcolumn_for_sparse_column_size =
_src_subcolumns_for_sparse.size();
+ size_t sorted_src_subcolumn_for_sparse_column_size =
+ _sorted_src_subcolumn_for_sparse.size();
Review Comment:
src subcolumns 应该打散到不同的bucket 里面
##########
be/src/olap/rowset/segment_v2/variant/variant_column_reader.cpp:
##########
@@ -390,8 +572,10 @@ Status
VariantColumnReader::new_iterator(ColumnIteratorUPtr* iterator,
// {"b" : {"c":456}} b.c in subcolumn
// {"b" : 123} b in sparse column
// Then we should use hierarchical reader to read b
+ auto [reader, cache_key] =
+
_sparse_reader.select_reader_and_cache_key(relative_path.get_path());
Review Comment:
可以利用每个bucket 的统计信息来查看命中哪个bucket
##########
be/src/olap/rowset/segment_v2/variant/variant_column_reader.cpp:
##########
@@ -390,8 +572,10 @@ Status
VariantColumnReader::new_iterator(ColumnIteratorUPtr* iterator,
// {"b" : {"c":456}} b.c in subcolumn
// {"b" : 123} b in sparse column
// Then we should use hierarchical reader to read b
+ auto [reader, cache_key] =
+
_sparse_reader.select_reader_and_cache_key(relative_path.get_path());
Review Comment:
如果查询的path 是一个层级的，这里有可能命中多个bucket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
