CalvinKirs commented on code in PR #57696:
URL: https://github.com/apache/doris/pull/57696#discussion_r2492785256
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalCatalog.java:
##########
@@ -158,6 +158,9 @@ public synchronized void resetToUninitialized(boolean
invalidCache) {
if (metadataOps != null) {
metadataOps.close();
}
+ if (icebergMetadataOps != null) {
+ icebergMetadataOps.close();
+ }
}
Review Comment:
I don’t think this PR really fixes the issue.
super.resetToUninitialized(invalidCache) calls onClose(), which releases the
resources, but it doesn’t set the object to null.
Since we check null to see if it’s initialized, you probably need to set it
to null after closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
