Copilot commented on code in PR #57736:
URL: https://github.com/apache/doris/pull/57736#discussion_r2493881605
##########
regression-test/suites/job_p0/streaming_job/test_streaming_insert_job.groovy:
##########
@@ -106,10 +106,17 @@ suite("test_streaming_insert_job") {
select currentOffset, endoffset, loadStatistic from
jobs("type"="insert") where Name='${jobName}'
"""
log.info("jobInfo: " + jobInfo)
- assert jobInfo.get(0).get(0) ==
"{\"endFile\":\"regression/load/data/example_1.csv\"}";
- assert jobInfo.get(0).get(1) ==
"{\"endFile\":\"regression/load/data/example_1.csv\"}";
+ assert jobInfo.get(0).get(0) ==
"{\"fileName\":\"regression/load/data/example_1.csv\"}";
+ assert jobInfo.get(0).get(1) ==
"{\"fileName\":\"regression/load/data/example_1.csv\"}";
assert jobInfo.get(0).get(2) ==
"{\"scannedRows\":20,\"loadBytes\":425,\"fileNumber\":2,\"fileSize\":256}"
-
+
+ // check task show
+ def taskInfo = sql """select Status,RunningOffset from
tasks("type"="insert") where jobName='${jobName}'"""
+ log.info("taskInfo is : " + taskInfo + ", size: " + taskInfo.size())
+ assert taskInfo.size() > 0
+ taskInfo.get(taskInfo.size()-1).get(0) == "SUCCESS"
+ taskInfo.get(taskInfo.size()-1).get(1) ==
"{\"startFileName\":\"regression/load/data/example_0.csv\",\"endFileName\":\"regression/load/data/example_0.csv\"}"
Review Comment:
Missing `assert` keyword on lines 117-118. These statements perform
comparisons but don't actually assert the results, so test failures would go
undetected.
```suggestion
assert taskInfo.get(taskInfo.size()-1).get(0) == "SUCCESS"
assert taskInfo.get(taskInfo.size()-1).get(1) ==
"{\"startFileName\":\"regression/load/data/example_0.csv\",\"endFileName\":\"regression/load/data/example_0.csv\"}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
