dataroaring commented on code in PR #57770:
URL: https://github.com/apache/doris/pull/57770#discussion_r2511972186
##########
be/src/olap/rowset/segment_v2/index_file_writer.cpp:
##########
@@ -128,6 +129,11 @@ Status IndexFileWriter::add_into_searcher_cache() {
// StreamSinkFileWriter not found file is normal.
return Status::OK();
}
+ if (dynamic_cast<io::MergeFileWriter*>(_idx_v2_writer.get()) !=
nullptr) {
+ // MergeFileWriter: file may be merged, skip cache for now.
+ // The cache will be populated on first read.
Review Comment:
Bad performance may be introduced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
