gavinchou commented on code in PR #57755:
URL: https://github.com/apache/doris/pull/57755#discussion_r2513098161
##########
be/src/service/internal_service.cpp:
##########
@@ -725,14 +725,21 @@ void
PInternalService::outfile_write_success(google::protobuf::RpcController* co
}
}
- auto&& res = FileFactory::create_file_writer(
-
FileFactory::convert_storage_type(result_file_sink.storage_backend_type),
- ExecEnv::GetInstance(), file_options.broker_addresses,
- file_options.broker_properties, file_name,
- {
- .write_file_cache = false,
- .sync_file_data = false,
- });
+ auto file_type_res =
+
FileFactory::convert_storage_type(result_file_sink.storage_backend_type);
+ if (!file_type_res.has_value()) [[unlikely]] {
+ st = std::move(file_type_res).error();
+ st.to_protobuf(result->mutable_status());
Review Comment:
LOG(WARNING) << "encounter unkonw type=" << type << " st=" <<st;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
