yujun777 commented on code in PR #57013:
URL: https://github.com/apache/doris/pull/57013#discussion_r2516473860


##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -207,6 +207,7 @@ public class PropertyAnalyzer {
     public static final String PROPERTIES_PARTITION_SYNC_LIMIT = 
"partition_sync_limit";
     public static final String PROPERTIES_PARTITION_TIME_UNIT = 
"partition_sync_time_unit";
     public static final String PROPERTIES_PARTITION_DATE_FORMAT = 
"partition_date_format";
+    public static final String PROPERTIES_PARTITION_RETENTION_COUNT = 
"partition.retention_count";

Review Comment:
   意思是后面有规划把 dynamic_partition.start / end / history_partition_num 给干掉 
?对于存量dynamic partition,这几个变量感觉比较难干掉。  start 和 history _partition_num 
之前的设计就很混乱,它们在建分区时表示一样的含义,但是删分区时含义又不完全相同。如果是考虑存量数据升级的,感觉dynamic_partition.start 
/ history_partition_num 比较难干掉



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to