gavinchou commented on code in PR #13332:
URL: https://github.com/apache/doris/pull/13332#discussion_r1002513501
##########
be/src/vec/columns/column_decimal.cpp:
##########
@@ -164,9 +164,18 @@ template <typename T>
void ColumnDecimal<T>::update_hashes_with_value(uint64_t* __restrict hashes,
const uint8_t* __restrict
null_data) const {
auto s = size();
- for (int i = 0; i < s; i++) {
- hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const
char*>(&data[i]), sizeof(T),
- hashes[i]);
+ if (null_data) {
Review Comment:
Would it be better to express the logic as the following to save LOC?
```
for (int i = 0; i < s; i++) {
if (null_data != nullptr && null_data[i] != 0) continue;
hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const
char*>(&data[i]), sizeof(T),
hashes[i]);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
