morningman commented on code in PR #13497:
URL: https://github.com/apache/doris/pull/13497#discussion_r1002617193
##########
fe/fe-core/src/main/java/org/apache/doris/policy/PolicyMgr.java:
##########
@@ -186,16 +200,25 @@ private boolean existPolicy(DropPolicyLog
checkedDropPolicy) {
* @return Policy in typeToPolicyMap
*/
public Policy getPolicy(Policy checkedPolicy) {
- List<Policy> policies = getPoliciesByType(checkedPolicy.getType());
- for (Policy policy : policies) {
- if (policy.matchPolicy(checkedPolicy)) {
- return policy;
+ readLock();
+ try {
+ List<Policy> policies = getPoliciesByType(checkedPolicy.getType());
+ for (Policy policy : policies) {
+ if (policy.matchPolicy(checkedPolicy)) {
+ return policy;
+ }
}
+ return null;
+ } finally {
+ readUnlock();
}
- return null;
}
- public List<Policy> getPoliciesByType(PolicyTypeEnum policyType) {
+ public List<Policy> getCopiedPoliciesByType(PolicyTypeEnum policyType) {
Review Comment:
This should also be wrapped with readlock
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
