HaolinGuan7211 commented on code in PR #57470:
URL: https://github.com/apache/doris/pull/57470#discussion_r2525462100
##########
be/src/cloud/cloud_schema_change_job.cpp:
##########
@@ -595,4 +604,26 @@ void CloudSchemaChangeJob::clean_up_on_failure() {
}
}
+bool CloudSchemaChangeJob::_should_cache_sc_output(
+ const std::vector<RowsetSharedPtr>& input_rowsets) {
+ int64_t total_size = 0;
+ int64_t cached_index_size = 0;
+ int64_t cached_data_size = 0;
+
+ for (const auto& rs : input_rowsets) {
+ const RowsetMetaSharedPtr& rs_meta = rs->rowset_meta();
+ total_size += rs_meta->total_disk_size();
+ cached_index_size += rs->approximate_cache_index_size();
+ cached_data_size += rs->approximate_cached_data_size();
+ }
+
+ double input_hit_rate = static_cast<double>(cached_index_size +
cached_data_size) / total_size;
+
+ if (input_hit_rate >
config::file_cache_keep_schema_change_output_min_hit_ratio) {
+ return true;
Review Comment:
Ok, I wiil add LOG here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
