suxiaogang223 opened a new pull request, #58033:
URL: https://github.com/apache/doris/pull/58033
### What problem does this PR solve?
Problem Summary:
Currently, the dynamic partition pruning feature for Iceberg tables has the
following issues:
1. **Does not consider partition evolution**: When processing partition
values, the code doesn't account for partition evolution scenarios where
different files may use different partition specs (specId). This can lead to
incorrect partition information being passed to BE.
2. **Processes all partition transform types**: The current implementation
processes all partition transform types (identity, day, bucket, truncate, etc.)
and passes partition information to BE for dynamic partition pruning. However,
for non-identity transforms (e.g., `day(ts)`, `bucket(16, id)`, `truncate(3,
name)`), the partition values are transformed values, not the original column
values, which can cause incorrect filtering behavior.
### Release note
This PR modifies the dynamic partition pruning logic to:
1. **Support partition evolution**:
- Get `specId` from `FileScanTask.file().specId()`
- Retrieve the corresponding `PartitionSpec` from
`icebergTable.specs().get(specId)`
- Pass the correct `PartitionSpec` to `getPartitionInfoMap()` to handle
different partition structures across different specIds
2. **Only process identity partitions**:
- Check if all partition fields use identity transform
- For identity partitions: extract and pass partition values to BE for
dynamic partition pruning
- For non-identity partitions (day, bucket, truncate, etc.): return
`null` to skip dynamic partition pruning, avoiding incorrect filtering
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
