linrrzqqq commented on code in PR #58004:
URL: https://github.com/apache/doris/pull/58004#discussion_r2532679138
##########
be/src/geo/wkt_parse.cpp:
##########
@@ -47,5 +47,16 @@ GeoParseStatus WktParse::parse_wkt(const char* str, size_t
len, GeoShape** shape
return ctx.parse_status;
}
+int WktParse::wkt_parse(const char* str, size_t len, WktParseContext& ctx) {
+ wkt_lex_init_extra(&ctx, &ctx.scaninfo);
+ YY_BUFFER_STATE buffer = wkt__scan_bytes(str, len, ctx.scaninfo);
+
+ wkt_::parser parser(&ctx, ctx.scaninfo);
Review Comment:
原先 yacc 会生成 c模式的代码，是不兼容 unique_ptr的，使用 cpp skeleton（
lalr1.cc）后，会致部分结构和对外接口的和原先的不一致
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
