HappenLee commented on code in PR #57824:
URL: https://github.com/apache/doris/pull/57824#discussion_r2532935037
##########
be/src/vec/data_types/serde/data_type_number_serde.cpp:
##########
@@ -911,7 +911,18 @@ template <PrimitiveType T>
void DataTypeNumberSerDe<T>::to_string(const IColumn& column, size_t row_num,
BufferWritable& bw) const {
auto& data = assert_cast<const ColumnType&,
TypeCheckOnRelease::DISABLE>(column).get_data();
- value_to_string<T>(data[row_num], bw, get_scale());
+ if constexpr (is_date_type(T) || is_time_type(T) || is_ip(T)) {
+ if (_nesting_level > 1) {
+ bw.write('"');
+ }
+ value_to_string<T>(data[row_num], bw, get_scale());
+ if (_nesting_level > 1) {
+ bw.write('"');
+ }
+
Review Comment:
unless empty line
##########
be/src/vec/data_types/serde/data_type_bitmap_serde.cpp:
##########
@@ -173,6 +173,21 @@ Status DataTypeBitMapSerDe::_write_column_to_mysql(const
IColumn& column,
return Status::OK();
}
+bool DataTypeBitMapSerDe::write_column_to_mysql_text(const IColumn& column,
BufferWritable& bw,
+ int64_t row_idx) const {
+ const auto& data_column = assert_cast<const ColumnBitmap&>(column);
+ if (_return_object_as_string) {
+ BitmapValue bitmapValue = data_column.get_element(row_idx);
Review Comment:
bitmap_value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
