This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new d20275358b6 [enhancement](wg) print error code when delete cgroup path
failed (#58126)
d20275358b6 is described below
commit d20275358b6b587f6b6f7b376e8fd4402963daa1
Author: yiguolei <[email protected]>
AuthorDate: Wed Nov 19 10:14:29 2025 +0800
[enhancement](wg) print error code when delete cgroup path failed (#58126)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
be/src/agent/cgroup_cpu_ctl.cpp | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/be/src/agent/cgroup_cpu_ctl.cpp b/be/src/agent/cgroup_cpu_ctl.cpp
index 06a38a989da..6404bf3fe55 100644
--- a/be/src/agent/cgroup_cpu_ctl.cpp
+++ b/be/src/agent/cgroup_cpu_ctl.cpp
@@ -292,7 +292,7 @@ Status
CgroupCpuCtl::delete_unused_cgroup_path(std::set<uint64_t>& used_wg_ids)
std::string wg_path = query_path + unused_wg_id;
int ret = rmdir(wg_path.c_str());
if (ret < 0) {
- LOG(WARNING) << "rmdir failed, path=" << wg_path;
+ LOG(WARNING) << "remove cgroup path failed, path=" << wg_path <<
", error=" << ret;
failed_count++;
}
}
@@ -317,7 +317,8 @@ Status CgroupV1CpuCtl::init() {
if (access(_cgroup_v1_cpu_tg_path.c_str(), F_OK) != 0) {
int ret = mkdir(_cgroup_v1_cpu_tg_path.c_str(), S_IRWXU);
if (ret != 0) {
- LOG(ERROR) << "cgroup v1 mkdir workload group failed, path=" <<
_cgroup_v1_cpu_tg_path;
+ LOG(WARNING) << "cgroup v1 make workload group dir failed, path="
+ << _cgroup_v1_cpu_tg_path << ", error=" << ret;
return Status::InternalError<false>("cgroup v1 mkdir workload
group failed, path={}",
_cgroup_v1_cpu_tg_path);
}
@@ -382,6 +383,8 @@ Status CgroupV2CpuCtl::init() {
if (access(_cgroup_v2_query_wg_path.c_str(), F_OK) != 0) {
int ret = mkdir(_cgroup_v2_query_wg_path.c_str(), S_IRWXU);
if (ret != 0) {
+ LOG(WARNING) << "cgroup v2 make workload group dir failed, path="
+ << _cgroup_v2_query_wg_path << ", error=" << ret;
return Status::InternalError<false>("cgroup v2 mkdir wg failed,
path={}",
_cgroup_v2_query_wg_path);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
