yujun777 commented on code in PR #57537:
URL: https://github.com/apache/doris/pull/57537#discussion_r2540989740
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PullUpPredicates.java:
##########
@@ -320,7 +320,8 @@ public ImmutableSet<Expression>
visitLogicalAggregate(LogicalAggregate<? extends
genPredicates =
FoldConstantRuleOnFE.evaluate(genPredicates, rewriteContext);
if (isScalar) {
// Aggregation will return null if there are
no matching rows
- pullPredicates.add(new Or(new IsNull(slot),
genPredicates));
+ // SimplifyRange will put IsNull at the back
+ pullPredicates.add(new Or(genPredicates, new
IsNull(slot)));
Review Comment:
this is problem of OR's equals and PullUpPredicate, Two OR equals require
they have the same child order, while PullUpPredicate only generate one OR
order.
But in fact, this problem no relation with this PR, this PR modify here is
just let pass a regression test which cause by the above problem.
Maybe can add a new PR to this problem of OR or PullUpPredicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
