yujun777 opened a new pull request, #58153:
URL: https://github.com/apache/doris/pull/58153

   ### What problem does this PR solve?
   
   when do sample,  it will use table.getRowCount() as rowsCount,   but the 
table.getRowCount() may be stale because it depend on BE's report,  then it may 
occur  rowsCount < ndv.
   
   Then when if 10 * rowsCount < ndv, the analyze sql will fail.
   
   Then the regression test statistics/analyze_stats.groovy is not stable,  and 
cause error:
   
   ```
   Exception:
   java.sql.SQLException: errCode = 2, detailMessage = Failed to analyze 
following columns:[id] Reasons: java.lang.RuntimeException: ColStatsData is 
invalid, skip analyzing. 
('1763112020393--1-id',0,1763112019723,1763112020393,-1,'id',null,1,16,0,'1','201',64,'2025-11-14
 17:41:14','105 :0.06 ;104 :0.06 ;103 :0.06 ;102 :0.06 ;101 :0.06 ;10 :0.06 ;9 
:0.06 ;8 :0.06 ;7 :0.06 ;6 :0.06')
     at 
com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
     at 
com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
     at 
com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:953)
     at 
com.mysql.cj.jdbc.ClientPreparedStatement.execute(ClientPreparedStatement.java:371)
     at 
org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)
     at 
org.apache.doris.regression.util.JdbcUtils$_executeToList_closure1.doCall(JdbcUtils.groovy:47)
     at sun.reflect.GeneratedMethodAccessor33.invoke(Unknown Source)
     at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
     at java.lang.reflect.Method.invoke(Method.java:498)
     at 
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:343)
     at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:328)
     at 
org.codehaus.groovy.runtime.metaclass.ClosureMetaClass.invokeMethod(ClosureMetaClass.java:279)
   ```
   
   so when do sample and scan whole table, we use count(1) to represent 
rowsCount.
   
   Notice that this replace will not increase the excute cost, because the 
staticstic sql has contained `count(1)`
   
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to