zhangstar333 commented on code in PR #57821:
URL: https://github.com/apache/doris/pull/57821#discussion_r2545077911
##########
be/src/vec/data_types/serde/data_type_varbinary_serde.h:
##########
@@ -39,18 +41,22 @@ class DataTypeVarbinarySerDe : public DataTypeSerDe {
std::string get_name() const override { return "Varbinary"; }
Status serialize_one_cell_to_json(const IColumn& column, int64_t row_num,
BufferWritable& bw,
- FormatOptions& options) const override {
- return Status::NotSupported("serialize_one_cell_to_json with type " +
column.get_name());
- }
+ FormatOptions& options) const override;
Status serialize_column_to_json(const IColumn& column, int64_t start_idx,
int64_t end_idx,
BufferWritable& bw, FormatOptions&
options) const override {
return Status::NotSupported("serialize_column_to_json with type " +
column.get_name());
}
Status deserialize_one_cell_from_json(IColumn& column, Slice& slice,
const FormatOptions& options) const
override {
- return Status::NotSupported("deserialize_one_cell_from_text with type
" +
- column.get_name());
+ if (_nesting_level >= 2) {
+ slice.trim_quote();
+ }
+ if (options.escape_char != 0) {
+ escape_string(slice.data, &slice.size, options.escape_char);
Review Comment:
en, i remove the escape logical
and now the json are mapping in string type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
