zclllyybb commented on code in PR #56200:
URL: https://github.com/apache/doris/pull/56200#discussion_r2497899205
##########
be/src/vec/functions/function_date_or_datetime_computation.h:
##########
@@ -1611,6 +1611,161 @@ class PeriodDiffImpl {
}
}
};
+#define ADD_TIME_FUNCTION(CLASS, NAME)
\
Review Comment:
what's this?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/format/TimeChecker.java:
##########
Review Comment:
why modify this?
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java:
##########
@@ -1021,7 +1024,8 @@ public class BuiltinScalarFunctions implements
FunctionHelper {
scalar(SubBitmap.class, "sub_bitmap"),
scalar(SubReplace.class, "sub_replace"),
scalar(Substring.class, "substr", "substring", "mid"),
- scalar(SubstringIndex.class, "substring_index"),
+ scalar(SubTime.class, "sub_time"),
+ scalar(SubstringIndex.class, "substring_index"),
Review Comment:
format
##########
fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java:
##########
@@ -921,6 +921,9 @@ public boolean matchesType(Type t) {
Preconditions.checkState(!isWildcardTimeV2());
return true;
}
+ if (isTimeV2() && scalarType.isTimeV2()) {
Review Comment:
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
