adonis0147 commented on code in PR #13723:
URL: https://github.com/apache/doris/pull/13723#discussion_r1006620151
##########
extension/mysql_to_doris/bin/e_mysql_to_doris.sh:
##########
@@ -31,8 +31,8 @@ rm -f $path
#get create table sql for mysql
for table in $(cat ../conf/mysql_tables |grep -v '#' | awk -F '\n' '{print
$1}')
do
- d_d=`echo $table` |awk -F '.' '{print $1}'
- d_t=`echo $table` |awk -F '.' '{print $2}'
+ d_d=`echo $table |awk -F '.' '{print $1}'`
+ d_t=`echo $table |awk -F '.' '{print $2}'`
Review Comment:
It is better to use this syntax.
```suggestion
d_d=$(echo $table |awk -F '.' '{print $1}')
d_t=$(echo $table |awk -F '.' '{print $2}')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
