gavinchou commented on code in PR #58301:
URL: https://github.com/apache/doris/pull/58301#discussion_r2564006203
##########
be/src/olap/rowset/rowset_meta.h:
##########
@@ -140,6 +140,17 @@ class RowsetMeta : public MetadataAdder<RowsetMeta> {
void set_num_rows(int64_t num_rows) {
_rowset_meta_pb.set_num_rows(num_rows); }
+ void set_segment_rows(const std::vector<uint32_t>& segment_rows) {
Review Comment:
suggest naming `set_num_segment_rows`
##########
be/src/olap/rowset/rowset_meta.h:
##########
@@ -140,6 +140,17 @@ class RowsetMeta : public MetadataAdder<RowsetMeta> {
void set_num_rows(int64_t num_rows) {
_rowset_meta_pb.set_num_rows(num_rows); }
+ void set_segment_rows(const std::vector<uint32_t>& segment_rows) {
+ _rowset_meta_pb.mutable_segment_rows()->Assign(segment_rows.cbegin(),
segment_rows.cend());
+ }
+
+ void get_segment_rows(std::vector<uint32_t>* segment_rows) const {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
