BiteTheDDDDt opened a new pull request, #58462:
URL: https://github.com/apache/doris/pull/58462

   ### What problem does this PR solve?
   doris have crc32c from rocksdb now, but it has poorly performance than 
google/crc32c.
   
   66663538 rows int
   crc32c-rocksdb 684.879ms
   crc32c-google 206.360ms
   
   66663538 rows varchar
   crc32c-rocksdb 1sec368ms
   crc32c-google 391.290ms
   
   This pull request adds support for the `crc32c` third-party dependency to 
the build environment. The changes include updating the changelog, adding build 
logic, and configuring the necessary variables to download and build `crc32c`.
   
   **Third-party dependency integration:**
   
   * Added `crc32c-1.1.2` to the list of third-party dependencies in the 
changelog (`thirdparty/CHANGELOG.md`).
   * Added `crc32c` to the default package build list in `build-thirdparty.sh` 
to ensure it is built by default.
   * Implemented the `build_crc32c()` function in `build-thirdparty.sh` to 
handle the build and installation process for `crc32c`.
   
   **Build configuration updates:**
   
   * Defined download URL, archive name, source directory, and MD5 checksum for 
`crc32c` in `vars.sh`.
   * Added `CRC32C` to the `TP_ARCHIVES` array in `vars.sh` so it is included 
in the set of managed third-party archives.
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to