eldenmoon opened a new pull request, #58485:
URL: https://github.com/apache/doris/pull/58485
- Replace the per-row seek + next_batch(1) loop in
MapFileColumnIterator::read_by_rowids with batched offset reads via
OffsetFileColumnIterator::read_by_rowids to derive key/value ranges for the
requested rowids.
- Compute per-row map sizes from offset[rowid] and offset[rowid+1], using
the page-tail next_array_item_ordinal sentinel for the last row when rowid+1 is
out of bounds.
- Skip key/value decoding for null rows by consulting a pre-fetched null
map, and add a safety check to reject non-nullable destination columns when the
underlying map reader is nullable.
- Reuse a small peek column in OffsetFileColumnIterator::_peek_one_offset to
avoid repeated temporary column allocations when reading page sentinels.
- Add a unit test (MapReadByRowidsSkipReadingResizesDestination) to verify
that read_by_rowids honors the SKIP_READING flag and only resizes the
destination column without touching sub-iterators.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
