This is an automated email from the ASF dual-hosted git repository.
zykkk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ef2cd4be852 [improvement](jdbc) Improve JdbcDataSource cleanup thread
reliability and observability (#58484)
ef2cd4be852 is described below
commit ef2cd4be852b11aae0c15f8092b2c76771a6c68b
Author: zy-kkk <[email protected]>
AuthorDate: Sun Nov 30 19:39:35 2025 +0800
[improvement](jdbc) Improve JdbcDataSource cleanup thread reliability and
observability (#58484)
Improve the JdbcDataSource cleanup thread by adding named thread factory
with daemon flag, startup and execution logging for better
observability, and using
iterator-based removal for safer concurrent iteration. These changes
make it easier to troubleshoot cleanup task issues and ensure JVM can
shutdown gracefully.
---
.../java/org/apache/doris/jdbc/JdbcDataSource.java | 30 +++++++++++++++++-----
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git
a/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/JdbcDataSource.java
b/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/JdbcDataSource.java
index 1aea763852f..a254924cbb3 100644
---
a/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/JdbcDataSource.java
+++
b/fe/be-java-extensions/jdbc-scanner/src/main/java/org/apache/doris/jdbc/JdbcDataSource.java
@@ -17,22 +17,29 @@
package org.apache.doris.jdbc;
+import com.google.common.util.concurrent.ThreadFactoryBuilder;
import com.zaxxer.hikari.HikariDataSource;
import org.apache.log4j.Logger;
+import java.util.Iterator;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ScheduledFuture;
+import java.util.concurrent.ThreadFactory;
import java.util.concurrent.TimeUnit;
public class JdbcDataSource {
private static final Logger LOG = Logger.getLogger(JdbcDataSource.class);
+ private static final ThreadFactory THREAD_FACTORY = new
ThreadFactoryBuilder()
+ .setDaemon(true)
+ .setNameFormat("jdbc-datasource-cleanup-%d")
+ .build();
private static final JdbcDataSource jdbcDataSource = new JdbcDataSource();
private final Map<String, HikariDataSource> sourcesMap = new
ConcurrentHashMap<>();
private final Map<String, Long> lastAccessTimeMap = new
ConcurrentHashMap<>();
- private final ScheduledExecutorService executor =
Executors.newSingleThreadScheduledExecutor();
+ private final ScheduledExecutorService executor =
Executors.newSingleThreadScheduledExecutor(THREAD_FACTORY);
private long cleanupInterval = 8 * 60 * 60 * 1000; // 8 hours
private ScheduledFuture<?> cleanupTask = null;
@@ -72,23 +79,34 @@ public class JdbcDataSource {
cleanupTask = executor.scheduleAtFixedRate(() -> {
try {
long now = System.currentTimeMillis();
- lastAccessTimeMap.forEach((key, lastAccessTime) -> {
+ int cleanedCount = 0;
+ Iterator<Map.Entry<String, Long>> iterator =
lastAccessTimeMap.entrySet().iterator();
+ while (iterator.hasNext()) {
+ Map.Entry<String, Long> entry = iterator.next();
+ String key = entry.getKey();
+ long lastAccessTime = entry.getValue();
if (now - lastAccessTime > cleanupInterval) {
HikariDataSource ds = sourcesMap.remove(key);
if (ds != null) {
ds.close();
}
- lastAccessTimeMap.remove(key);
+ iterator.remove();
+ cleanedCount++;
LOG.info("remove jdbc data source: " +
key.split("jdbc")[0]);
}
- });
+ }
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("jdbc datasource cleanup task executed, cleaned:
" + cleanedCount
+ + ", remaining: " + sourcesMap.size());
+ }
} catch (Exception e) {
- LOG.error("failed to cleanup jdbc data source", e);
+ LOG.warn("failed to cleanup jdbc data source", e);
}
}, cleanupInterval, cleanupInterval, TimeUnit.MILLISECONDS);
+ LOG.info("jdbc datasource cleanup task started, interval: " +
cleanupInterval + "ms");
}
- private void startCleanupTask() {
+ private synchronized void startCleanupTask() {
if (cleanupTask == null || cleanupTask.isCancelled()) {
restartCleanupTask();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
