zhangstar333 commented on code in PR #58528:
URL: https://github.com/apache/doris/pull/58528#discussion_r2579492656
##########
be/src/vec/exec/format/parquet/parquet_column_convert.h:
##########
@@ -354,6 +355,86 @@ class FixedSizeBinaryConverter : public
PhysicalToLogicalConverter {
}
};
+class Float16PhysicalConverter : public PhysicalToLogicalConverter {
+private:
+ int _type_length;
+
+public:
+ Float16PhysicalConverter(int type_length) : _type_length(type_length) {
+ DCHECK_EQ(_type_length, 2);
+ }
+
+ Status physical_convert(ColumnPtr& src_physical_col, ColumnPtr&
src_logical_column) override {
+ ColumnPtr from_col = remove_nullable(src_physical_col);
+ MutableColumnPtr to_col =
remove_nullable(src_logical_column)->assume_mutable();
+
+ const auto* src_data = assert_cast<const ColumnUInt8*>(from_col.get());
+ size_t length = src_data->size();
+ size_t num_values = length / _type_length;
+ auto* to_float_column = assert_cast<ColumnFloat32*>(to_col.get());
+ const uint8_t* ptr = src_data->get_data().data();
+ for (int i = 0; i < num_values; ++i) {
+ size_t offset = i * _type_length;
+ const uint8_t* data_ptr = ptr + offset;
+ uint16_t raw;
+ memcpy(&raw, data_ptr, sizeof(uint16_t));
Review Comment:
ptr is uint_8, use memcpy to avoid some align problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
