freemandealer commented on code in PR #57922:
URL: https://github.com/apache/doris/pull/57922#discussion_r2580369577
##########
be/src/cloud/cloud_storage_engine.cpp:
##########
@@ -280,11 +280,34 @@ bool CloudStorageEngine::stopped() {
Result<BaseTabletSPtr> CloudStorageEngine::get_tablet(int64_t tablet_id,
SyncRowsetStats*
sync_stats,
- bool
force_use_only_cached) {
- return _tablet_mgr->get_tablet(tablet_id, false, true, sync_stats,
force_use_only_cached)
+ bool
force_use_only_cached,
+ bool cache_on_miss) {
+ return _tablet_mgr
+ ->get_tablet(tablet_id, false, true, sync_stats,
force_use_only_cached, cache_on_miss)
.transform([](auto&& t) { return
static_pointer_cast<BaseTablet>(std::move(t)); });
}
+Status CloudStorageEngine::get_tablet_meta(int64_t tablet_id,
TabletMetaSharedPtr* tablet_meta,
Review Comment:
Not really. We only have 'tablet cache', not 'tablet meta cache'. Since we
don't cache tablet meta itself, `cache_on_miss` is always FALSE in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
