zclllyybb commented on code in PR #58592:
URL: https://github.com/apache/doris/pull/58592#discussion_r2581011632
##########
be/src/vec/runtime/time_value.h:
##########
@@ -150,6 +151,234 @@ class TimeValue {
}
static bool valid(double time) { return time <= MAX_TIME && time >=
-MAX_TIME; }
+
+ static bool to_format_string_conservative(const char* format, size_t len,
char* to,
Review Comment:
这个和date_format能否抽象出来同一个base函数呢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
