Gabriel39 commented on code in PR #58490:
URL: https://github.com/apache/doris/pull/58490#discussion_r2583497425
##########
be/src/vec/aggregate_functions/aggregate_function_min_max.cpp:
##########
@@ -129,35 +129,37 @@ AggregateFunctionPtr
create_aggregate_function_single_value(const String& name,
return creator_without_type::create_unary_arguments<
AggregateFunctionsSingleValue<Data<SingleValueDataDecimal<TYPE_DECIMAL256>>>>(
argument_types, result_is_nullable, attr);
- default:
- return nullptr;
- }
-}
-
-// any_value
-template <template <typename> class Data>
-AggregateFunctionPtr create_aggregate_function_single_value_any_value_function(
- const String& name, const DataTypes& argument_types, const bool
result_is_nullable,
- const AggregateFunctionAttr& attr) {
- AggregateFunctionPtr res = create_aggregate_function_single_value<Data>(
- name, argument_types, result_is_nullable, attr);
- if (res) {
- return res;
- }
- const DataTypePtr& argument_type = remove_nullable(argument_types[0]);
- if (argument_type->get_primitive_type() == PrimitiveType::TYPE_ARRAY ||
- argument_type->get_primitive_type() == PrimitiveType::TYPE_MAP ||
- argument_type->get_primitive_type() == PrimitiveType::TYPE_STRUCT ||
- argument_type->get_primitive_type() == PrimitiveType::TYPE_AGG_STATE ||
- argument_type->get_primitive_type() == PrimitiveType::TYPE_BITMAP ||
- argument_type->get_primitive_type() == PrimitiveType::TYPE_HLL ||
- argument_type->get_primitive_type() ==
PrimitiveType::TYPE_QUANTILE_STATE) {
+ case PrimitiveType::TYPE_ARRAY:
+ return creator_without_type::create_unary_arguments<
+
AggregateFunctionsSingleValue<Data<SingleValueDataComplexType>>>(
+ argument_types, result_is_nullable, attr);
+ case PrimitiveType::TYPE_MAP:
Review Comment:
`TYPE_MAP` and `TYPE_STRUCT` are supported on BE but illegal on FE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
