gavinchou commented on code in PR #58459:
URL: https://github.com/apache/doris/pull/58459#discussion_r2583756051
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -2567,30 +2567,57 @@ void
MetaServiceImpl::commit_rowset(::google::protobuf::RpcController* controlle
return;
}
- // Check if the compaction/sc tablet job has finished
- bool is_versioned_read = is_version_read_enabled(instance_id);
- if (config::enable_tablet_job_check && request->has_tablet_job_id() &&
- !request->tablet_job_id().empty()) {
- if (!check_job_existed(txn.get(), code, msg, instance_id, tablet_id,
rowset_id,
- request->tablet_job_id(), is_versioned_read,
resource_mgr_.get())) {
+ auto recycle_rs_key = recycle_rowset_key({instance_id, tablet_id,
rowset_id});
+ std::string recycle_rs_val;
+ err = txn->get(recycle_rs_key, &recycle_rs_val);
+ if (err == TxnErrorCode::TXN_OK) {
Review Comment:
move this block after the original check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
