morrySnow opened a new pull request, #58680:
URL: https://github.com/apache/doris/pull/58680
### What problem does this PR solve?
Problem Summary:
This pull request removes support for evaluating partition expressions
defined as functions (e.g., function(column)) during partition pruning and
related logic. The changes simplify the handling of binary predicates by
eliminating function-based partition expression handling, and remove several
related classes and utilities that are no longer needed.
Key changes include:
**Removal of function-based partition expression support:**
* The `invokeFunctionExpr` method and all related logic for handling
`FunctionCallExpr` in partition expressions have been removed from
`BinaryPredicate`. The `getSlotBinding` method now only supports direct slot
references and no longer accepts or processes a list of partition expressions.
[[1]](diffhunk://#diff-f491835ce20e42c028131456251d8c55595f933c9cff3fa24cae8f49398c2cc8L193-L245)
[[2]](diffhunk://#diff-f491835ce20e42c028131456251d8c55595f933c9cff3fa24cae8f49398c2cc8L256-L274)
* The `ScanNode` class has been updated to stop passing partition
expressions to `getSlotBinding`, reflecting the simplified interface.
[[1]](diffhunk://#diff-cf5d50dd05d6bc67971a030ce14568d4cef15441387f152b561c888af7449611L262-R262)
[[2]](diffhunk://#diff-cf5d50dd05d6bc67971a030ce14568d4cef15441387f152b561c888af7449611L355-R352)
**Code cleanup and removal of unused utilities:**
* The entire `ExpressionFunctions` class, which provided function evaluation
utilities for partition expressions, has been deleted.
* The annotation classes `FEFunction` and `FEFunctionList`, which were used
for registering and managing function metadata for partition pruning, have also
been removed.
[[1]](diffhunk://#diff-341fd18912433d2314de90785019094bbaea1fd99346e9eb34b647989d7320f0L1-L33)
[[2]](diffhunk://#diff-47b3cfee971787db2e7a971765133b3035a7cef3d5c7572d6e03132576bca135L1-L29)
These changes collectively simplify the codebase and partition pruning logic
by removing support and code paths for function-based partition expressions.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [x] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
