yiguolei commented on code in PR #58582:
URL: https://github.com/apache/doris/pull/58582#discussion_r2587190925
##########
be/src/olap/in_list_predicate.h:
##########
@@ -62,15 +62,26 @@ namespace doris {
* @tparam PT
* @tparam HybridSetType
*/
-template <PrimitiveType Type, PredicateType PT, typename HybridSetType>
-class InListPredicateBase : public ColumnPredicate {
+template <PrimitiveType Type, PredicateType PT, int N>
+class InListPredicateBase final : public ColumnPredicate {
public:
+ ENABLE_FACTORY_CREATOR(InListPredicateBase);
using T = typename PrimitiveTypeTraits<Type>::CppType;
+ using HybridSetType = std::conditional_t<
+ N >= 1 && N <= FIXED_CONTAINER_MAX_SIZE,
+ std::conditional_t<
+ std::is_same_v<T, StringRef>,
StringSet<FixedContainer<std::string, N>>,
+ HybridSet<Type, FixedContainer<T, N>,
+
vectorized::PredicateColumnType<PredicateEvaluateType<Type>>>>,
+ std::conditional_t<
+ std::is_same_v<T, StringRef>,
StringSet<DynamicContainer<std::string>>,
+ HybridSet<Type, DynamicContainer<T>,
+
vectorized::PredicateColumnType<PredicateEvaluateType<Type>>>>>;
template <typename ConditionType, typename ConvertFunc>
InListPredicateBase(uint32_t column_id, const ConditionType& conditions,
Review Comment:
为啥这里还要传递conditions 这些内容，以及在85 行这种convert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
