Copilot commented on code in PR #3163:
URL: https://github.com/apache/doris-website/pull/3163#discussion_r2595312950


##########
versioned_docs/version-4.x/sql-manual/sql-functions/scalar-functions/other-functions/grouping-id.md:
##########
@@ -50,18 +50,18 @@ ORDER BY GROUPING_ID(department, level) ASC;
 +--------------------+---------------------------+----------------+
 | department         | Job Title                 | Employee Count |
 +--------------------+---------------------------+----------------+
-| Board of Directors | Senior                    |              2 |
 | Technology         | Senior                    |              3 |
-| Sales              | Senior                    |              1 |
+| Technology         | Total: Technology         |              3 |
 | Sales              | Assistant                 |              2 |
+| Sales              | Total: Sales              |              4 |
 | Sales              | Trainee                   |              1 |
+| Sales              | Senior                    |              1 |
 | Marketing          | Senior                    |              1 |
-| Marketing          | Trainee                   |              2 |
 | Marketing          | Assistant                 |              1 |
-| Board of Directors | Total: Board of Directors |              2 |
-| Technology         | Total: Technology         |              3 |
-| Sales              | Total: Sales              |              4 |
 | Marketing          | Total: Marketing          |              4 |
+| Marketing          | Trainee                   |              2 |
+| Board of Directors | Senior                    |              2 |
+| Board of Directors | Total: Board of Directors |              2 |
 | NULL               | Total: Company            |             13 |

Review Comment:
   The expected output may be incorrect for `ORDER BY department DESC`. In most 
SQL databases, when ordering by a column in descending order, NULL values 
typically appear first (as they are considered the highest value). However, 
this output shows NULL at the bottom. Please verify this output matches the 
actual query results, or consider adding a note about NULL handling in the 
ordering if this behavior is specific to this database system.



##########
versioned_docs/version-3.x/sql-manual/sql-functions/aggregate-functions/grouping-id.md:
##########
@@ -50,18 +50,18 @@ ORDER BY GROUPING_ID(department, level) ASC;
 +--------------------+---------------------------+----------------+
 | department         | Job Title                 | Employee Count |
 +--------------------+---------------------------+----------------+
-| Board of Directors | Senior                    |              2 |
 | Technology         | Senior                    |              3 |
-| Sales              | Senior                    |              1 |
+| Technology         | Total: Technology         |              3 |
 | Sales              | Assistant                 |              2 |
+| Sales              | Total: Sales              |              4 |
 | Sales              | Trainee                   |              1 |
+| Sales              | Senior                    |              1 |
 | Marketing          | Senior                    |              1 |
-| Marketing          | Trainee                   |              2 |
 | Marketing          | Assistant                 |              1 |
-| Board of Directors | Total: Board of Directors |              2 |
-| Technology         | Total: Technology         |              3 |
-| Sales              | Total: Sales              |              4 |
 | Marketing          | Total: Marketing          |              4 |
+| Marketing          | Trainee                   |              2 |
+| Board of Directors | Senior                    |              2 |
+| Board of Directors | Total: Board of Directors |              2 |
 | NULL               | Total: Company            |             13 |

Review Comment:
   The expected output may be incorrect for `ORDER BY department DESC`. In most 
SQL databases, when ordering by a column in descending order, NULL values 
typically appear first (as they are considered the highest value). However, 
this output shows NULL at the bottom. Please verify this output matches the 
actual query results, or consider adding a note about NULL handling in the 
ordering if this behavior is specific to this database system.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to