morningman commented on code in PR #58679:
URL: https://github.com/apache/doris/pull/58679#discussion_r2598968470
##########
be/src/vec/exec/scan/file_scanner.cpp:
##########
@@ -1123,6 +1135,10 @@ Status FileScanner::_get_next_reader() {
_cur_reader =
RemoteDorisReader::create_unique(_file_slot_descs,
_state, _profile, range);
init_status =
((RemoteDorisReader*)(_cur_reader.get()))->init_reader();
+ if (_cur_reader) {
Review Comment:
ditto
##########
be/src/vec/exec/scan/file_scanner.cpp:
##########
@@ -1110,6 +1117,11 @@ Status FileScanner::_get_next_reader() {
_cur_reader = AvroJNIReader::create_unique(_state, _profile,
*_params, _file_slot_descs,
range);
init_status = ((AvroJNIReader*)(_cur_reader.get()))->init_reader();
+ // Set col_name_to_block_idx for JNI readers to avoid repeated map
creation
+ if (_cur_reader) {
Review Comment:
This `if (_cur_reader)` is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
