Copilot commented on code in PR #3170: URL: https://github.com/apache/doris-website/pull/3170#discussion_r2600840525
########## i18n/zh-CN/docusaurus-plugin-content-docs/version-4.x/admin-manual/config/be-config.md: ########## @@ -647,9 +647,15 @@ BaseCompaction:546859: #### `update_replica_infos_interval_seconds` +* 类型：int32 * 描述：更新 peer replica infos 的最小间隔时间 * 默认值：60（s） +#### `cold_data_compaction_score_threshold` + +* 类型：int32 +* 描述：该配置项指定触发冷数据 compaction 的最小 compaction 分数阈值。当冷数据的 compaction 分数超过该阈值时，会触发 compaction。调整该值有助于控制远程存储（如冷数据）上的 compaction 频率和激进程度。自 3.1.3 版本起支持。 +* 默认值：100 Review Comment: Incomplete documentation: The Chinese version-4.x file only documents `cold_data_compaction_score_threshold`, but is missing documentation for the other two cold data compaction configurations: `cold_data_compaction_thread_num` and `cold_data_compaction_interval_sec` that are documented in other language/version files. All three configurations should be documented consistently across all versions. ```suggestion #### `cold_data_compaction_thread_num` * 类型：int32 * 描述：用于冷数据 compaction 的线程数量。该配置项用于限制并发执行冷数据 compaction 的线程数，以避免对系统资源造成过大压力。 * 默认值：1 #### `cold_data_compaction_interval_sec` * 类型：int32 * 描述：冷数据 compaction 的执行间隔时间（秒）。该配置项用于控制冷数据 compaction 的定期执行频率，合理设置可平衡资源消耗与数据整理效率。 * 默认值：3600 ``` ########## versioned_docs/version-3.x/admin-manual/config/be-config.md: ########## @@ -638,9 +638,27 @@ BaseCompaction:546859: #### `update_replica_infos_interval_seconds` +* Type: int32 * Description: Minimal interval (s) to update peer replica infos * Default value: 60 (s) +#### `cold_data_compaction_score_threshold` + +* Type: int32 +* Description: This configuration specifies the minimum compaction score threshold for cold data before triggering compaction. When the compaction score of cold data exceeds this threshold, compaction will be considered. Adjusting this value helps control the frequency and aggressiveness of compaction on cold data in remote storage. Supported since 3.1.3. +* Default value: 100 + +#### `cold_data_compaction_thread_num` + +* Type: int32 +* Description: The number of threads used for cold data compaction. This configuration controls the degree of parallelism for cold data compaction tasks. Increasing this value allows more compaction tasks on cold data to run simultaneously, which may improve throughput but also increase resource usage. +* Default value: 2 + +#### `cold_data_compaction_interval_sec` + +* Type: int32 Review Comment: Inconsistency in documentation completeness: The English version-3.x file is missing the "Type: int32" field for `cold_data_compaction_interval_sec` configuration, while `cold_data_compaction_score_threshold` has it added on line 647. All three new configuration entries should include the Type field for consistency, just as was done for `update_replica_infos_interval_seconds` on line 641. ```suggestion * Type: int32 * Type: int32 ``` ########## versioned_docs/version-3.x/admin-manual/config/be-config.md: ########## @@ -638,9 +638,27 @@ BaseCompaction:546859: #### `update_replica_infos_interval_seconds` +* Type: int32 * Description: Minimal interval (s) to update peer replica infos * Default value: 60 (s) +#### `cold_data_compaction_score_threshold` + +* Type: int32 +* Description: This configuration specifies the minimum compaction score threshold for cold data before triggering compaction. When the compaction score of cold data exceeds this threshold, compaction will be considered. Adjusting this value helps control the frequency and aggressiveness of compaction on cold data in remote storage. Supported since 3.1.3. +* Default value: 100 + +#### `cold_data_compaction_thread_num` + +* Type: int32 +* Description: The number of threads used for cold data compaction. This configuration controls the degree of parallelism for cold data compaction tasks. Increasing this value allows more compaction tasks on cold data to run simultaneously, which may improve throughput but also increase resource usage. +* Default value: 2 Review Comment: Inconsistency in documentation completeness: The English version-3.x file is missing the "Type: int32" field for `cold_data_compaction_thread_num` and `cold_data_compaction_interval_sec` configurations, while `cold_data_compaction_score_threshold` has it added on line 647. All three new configuration entries should include the Type field for consistency, just as was done for `update_replica_infos_interval_seconds` on line 641. ########## versioned_docs/version-4.x/admin-manual/config/be-config.md: ########## @@ -636,9 +636,28 @@ BaseCompaction:546859: #### `update_replica_infos_interval_seconds` +* Type: int32 * Description: Minimal interval (s) to update peer replica infos * Default value: 60 (s) +#### `cold_data_compaction_score_threshold` + +* Type: int32 +* Description: This configuration specifies the minimum compaction score threshold for cold data before triggering compaction. When the compaction score of cold data exceeds this threshold, compaction will be considered. Adjusting this value helps control the frequency and aggressiveness of compaction on cold data in remote storage. Supported since 3.1.3. +* Default value: 100 + +#### `cold_data_compaction_thread_num` + +* Type: int32 +* Description: The number of threads used for cold data compaction. This configuration controls the degree of parallelism for cold data compaction tasks. Increasing this value allows more compaction tasks on cold data to run simultaneously, which may improve throughput but also increase resource usage. +* Default value: 2 + +#### `cold_data_compaction_interval_sec` + +* Type: int32 +* Description: The time interval in seconds between triggers for cold data compaction. A shorter interval means compaction on cold data will be considered more frequently, potentially leading to faster cleanup but higher resource consumption. +* Default value: 1800 (seconds) Review Comment: Inconsistency in documentation completeness: The English version-4.x file is missing the "Type: int32" field for `cold_data_compaction_interval_sec` configuration, while `cold_data_compaction_score_threshold` has it added on line 645. All three new configuration entries should include the Type field for consistency, just as was done for `update_replica_infos_interval_seconds` on line 639. ########## versioned_docs/version-4.x/admin-manual/config/be-config.md: ########## @@ -636,9 +636,28 @@ BaseCompaction:546859: #### `update_replica_infos_interval_seconds` +* Type: int32 * Description: Minimal interval (s) to update peer replica infos * Default value: 60 (s) +#### `cold_data_compaction_score_threshold` + +* Type: int32 +* Description: This configuration specifies the minimum compaction score threshold for cold data before triggering compaction. When the compaction score of cold data exceeds this threshold, compaction will be considered. Adjusting this value helps control the frequency and aggressiveness of compaction on cold data in remote storage. Supported since 3.1.3. +* Default value: 100 + +#### `cold_data_compaction_thread_num` + +* Type: int32 +* Description: The number of threads used for cold data compaction. This configuration controls the degree of parallelism for cold data compaction tasks. Increasing this value allows more compaction tasks on cold data to run simultaneously, which may improve throughput but also increase resource usage. +* Default value: 2 Review Comment: Inconsistency in documentation completeness: The English version-4.x file is missing the "Type: int32" field for `cold_data_compaction_thread_num` and `cold_data_compaction_interval_sec` configurations, while `cold_data_compaction_score_threshold` has it added on line 645. All three new configuration entries should include the Type field for consistency, just as was done for `update_replica_infos_interval_seconds` on line 639. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
