liaoxin01 commented on code in PR #58839:
URL: https://github.com/apache/doris/pull/58839#discussion_r2601286797
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -324,38 +324,93 @@ Status
BaseBetaRowsetWriter::_generate_delete_bitmap(int32_t segment_id) {
(_context.partial_update_info &&
_context.partial_update_info->is_partial_update())) {
return Status::OK();
}
- RowsetSharedPtr rowset_ptr;
- RETURN_IF_ERROR(_build_tmp(rowset_ptr));
- auto beta_rowset = reinterpret_cast<BetaRowset*>(rowset_ptr.get());
- std::vector<segment_v2::SegmentSharedPtr> segments;
- RETURN_IF_ERROR(beta_rowset->load_segments(segment_id, segment_id + 1,
&segments));
std::vector<RowsetSharedPtr> specified_rowsets;
{
std::shared_lock meta_rlock(_context.tablet->get_header_lock());
specified_rowsets =
_context.tablet->get_rowset_by_ids(_context.mow_context->rowset_ids.get());
}
- OlapStopWatch watch;
- auto finish_callback = [this](segment_v2::SegmentSharedPtr segment, Status
st) {
- auto* task = calc_delete_bitmap_task(segment->id());
- task->set_status(st);
- };
Review Comment:
I using a `Defer` to replace the finish callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
