sollhui opened a new pull request, #58843:
URL: https://github.com/apache/doris/pull/58843
pick #58275
Now, pages of column writer will be released after write all memtable block
in the scenario of partial updates, the process is as follows:
1. create all column_writer
2. append all column_writer (significant amount of memory expansion)
3. finish and free memory. This implement will cause a significant amount of
memory expansion when flushing memtable(The larger the number of columns, the
more obvious it is), and make load could easily cancelled by memory manager
when table column too wide(such as 5000 column).
This pr implement freeing memory column by column for partial update to
solve the problem, the process is as follows:
1. create all column_writer
2. append column_writer and free memory column by column. Test using
machines with specifications of 16c and 64G with 5000 column table:
- Before this pr, `VerticalSegmentWriter::_create_column_writer` occupies
nearly 20% of the memory.
- After fix, ` VerticalSegmentWriter::_create_column_writer` hardly occupies
memory.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
