eldenmoon commented on code in PR #58851:
URL: https://github.com/apache/doris/pull/58851#discussion_r2605379788


##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -1318,12 +1321,33 @@ Status StructFileColumnIterator::read_by_rowids(const 
rowid_t* rowids, const siz
         return Status::OK();
     }
 
-    for (size_t i = 0; i < count; ++i) {
-        RETURN_IF_ERROR(seek_to_ordinal(rowids[i]));
-        size_t num_read = 1;
+    if (count == 0) {
+        return Status::OK();
+    }
+
+    size_t this_run = 1;

Review Comment:
   maybe need to add ut



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to