zclllyybb commented on code in PR #58955:
URL: https://github.com/apache/doris/pull/58955#discussion_r2609633688
##########
be/src/vec/common/cow.h:
##########
@@ -314,9 +316,15 @@ class COW {
public:
MutablePtr mutate() const&& { return shallow_mutate(); }
- MutablePtr assume_mutable() const { return
const_cast<COW*>(this)->get_ptr(); }
+ MutablePtr assume_mutable() const {
Review Comment:
这个我们是不是语义改成assert_mutable，然后always check一下，没多少开销啊？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
