zclllyybb commented on code in PR #58554:
URL: https://github.com/apache/doris/pull/58554#discussion_r2611573115
##########
be/src/vec/functions/function_date_or_datetime_computation.cpp:
##########
@@ -119,10 +120,19 @@ using FunctionDatetimeSubQuarters =
using FunctionDatetimeSubYears =
FunctionDateOrDateTimeComputation<SubtractYearsImpl<TYPE_DATETIMEV2>>;
-using FunctionAddTimeDatetime = FunctionAddTime<TYPE_DATETIMEV2, AddTimeImpl>;
-using FunctionAddTimeTime = FunctionAddTime<TYPE_TIMEV2, AddTimeImpl>;
-using FunctionSubTimeDatetime = FunctionAddTime<TYPE_DATETIMEV2, SubTimeImpl>;
-using FunctionSubTimeTime = FunctionAddTime<TYPE_TIMEV2, SubTimeImpl>;
+using FunctionAddTimeDatetime =
+ FunctionNeedsToHandleNull<FunctionAddTimeImpl<TYPE_DATETIMEV2,
AddTimeImpl>,
+ TYPE_DATETIMEV2>;
+using FunctionAddTimeTime =
+ FunctionNeedsToHandleNull<FunctionAddTimeImpl<TYPE_TIMEV2,
AddTimeImpl>, TYPE_TIMEV2>;
+using FunctionSubTimeDatetime =
+ FunctionNeedsToHandleNull<FunctionAddTimeImpl<TYPE_DATETIMEV2,
SubTimeImpl>,
+ TYPE_DATETIMEV2>;
+using FunctionSubTimeTime =
+ FunctionNeedsToHandleNull<FunctionAddTimeImpl<TYPE_TIMEV2,
SubTimeImpl>, TYPE_TIMEV2>;
+using FunctionTimestampTwoArgs =
Review Comment:
这种为啥不直接在FE改写了呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
