yujun777 commented on code in PR #58978:
URL: https://github.com/apache/doris/pull/58978#discussion_r2613177794
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalAggregate.java:
##########
@@ -425,6 +425,7 @@ public void computeUnique(DataTrait.Builder builder) {
}
DataTrait childFd = child(0).getLogicalProperties().getTrait();
ImmutableSet<Slot> groupByKeys = groupByExpressions.stream()
+ .filter(s -> s instanceof Slot)
Review Comment:
1) if any group by expression containsUniqueFunctions， not unique;
2) otherwise extract all the slots from the group by expressions into a set,
for each group by key, groupByKeys.addAll(key.getInputSlots()), check then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
