This is an automated email from the ASF dual-hosted git repository.
jakevin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 0ea7f85986 [fix](keyword) add BIN as keyword (#13907)
0ea7f85986 is described below
commit 0ea7f85986b6a37ea3263630e28882613c67ddfa
Author: Mingyu Chen <[email protected]>
AuthorDate: Wed Nov 2 22:30:43 2022 +0800
[fix](keyword) add BIN as keyword (#13907)
---
fe/fe-core/src/main/cup/sql_parser.cup | 2 +
.../data/correctness_p0/test_keywords.out | 5 +++
.../suites/correctness_p0/test_keywords.groovy | 43 ++++++++++++++++++++++
3 files changed, 50 insertions(+)
diff --git a/fe/fe-core/src/main/cup/sql_parser.cup
b/fe/fe-core/src/main/cup/sql_parser.cup
index c9c6260c60..a9cf6b3dea 100644
--- a/fe/fe-core/src/main/cup/sql_parser.cup
+++ b/fe/fe-core/src/main/cup/sql_parser.cup
@@ -6349,6 +6349,8 @@ keyword ::=
{: RESULT = id; :}
| KW_BEGIN:id
{: RESULT = id; :}
+ | KW_BIN:id
+ {: RESULT = id; :}
| KW_BITMAP:id
{: RESULT = id; :}
| KW_QUANTILE_STATE:id
diff --git a/regression-test/data/correctness_p0/test_keywords.out
b/regression-test/data/correctness_p0/test_keywords.out
new file mode 100644
index 0000000000..512c06bec3
--- /dev/null
+++ b/regression-test/data/correctness_p0/test_keywords.out
@@ -0,0 +1,5 @@
+-- This file is automatically generated. You should know what you did if you
want to edit this
+-- !select --
+1
+10
+
diff --git a/regression-test/suites/correctness_p0/test_keywords.groovy
b/regression-test/suites/correctness_p0/test_keywords.groovy
new file mode 100644
index 0000000000..e4af2a6edf
--- /dev/null
+++ b/regression-test/suites/correctness_p0/test_keywords.groovy
@@ -0,0 +1,43 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+// Test some keywords that may conflict.
+// For example, "bin" is used for function "bin",
+// and also used "show catalog recycle bin"
+suite("test_keywords") {
+ def table = "test_keywords"
+ sql """
+ drop table if exists $table
+ """
+
+ sql """
+ create table $table ( k1 int, k2 varchar(1024) )
+ DISTRIBUTED BY HASH(k1) BUCKETS 3
+ PROPERTIES (
+ "replication_allocation" = "tag.location.default: 1"
+ );
+ """
+
+ sql """
+ insert into $table values(1, "abc"), (2, "xyz");
+ """
+
+ sql "sync"
+ order_qt_select """
+ select bin(k1) from $table
+ """
+}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
