yiguolei commented on code in PR #59009:
URL: https://github.com/apache/doris/pull/59009#discussion_r2617744007
##########
be/src/olap/comparison_predicate.h:
##########
@@ -266,6 +266,8 @@ class ComparisonPredicateBase final : public
ColumnPredicate {
return _value < tmp_min_value;
} else if constexpr (PT == PredicateType::GE) {
return _value <= tmp_min_value;
+ } else if constexpr (PT == PredicateType::EQ) {
+ return _value == tmp_min_value && _value == tmp_max_value;
}
Review Comment:
可以再column reader 中参考default column iterator的做法，看看这个segment
这个列的值是不是常量，如果是常量，直接返回const column就行了。
这个不仅仅是对于delete sign，感觉可以通用的对所有的列这么做。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
