englefly commented on code in PR #13949:
URL: https://github.com/apache/doris/pull/13949#discussion_r1012660945
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterContext.java:
##########
@@ -62,8 +61,10 @@ public class RuntimeFilterContext {
private final Map<PhysicalHashJoin, List<RuntimeFilter>>
runtimeFilterOnHashJoinNode = Maps.newHashMap();
- // Alias's child to itself.
- private final Map<Slot, NamedExpression> aliasChildToSelf =
Maps.newHashMap();
+ // alias -> alias's child, if there's a key that is alias's child, the
key-value will change by this way
+ // Alias(A) = B, now B -> A in map, and encounter Alias(B) -> C, the kv
will be C -> A.
+ // you can see disjoint set data structure to learn the processing
detailed.
+ private final Map<NamedExpression, Pair<RelationId, NamedExpression>>
aliasTransferMap = Maps.newHashMap();
Review Comment:
according to the comments, maybe Map<Pair<RelationId, NamedExpression>,
NamedExpression> is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
