freemandealer commented on code in PR #58922:
URL: https://github.com/apache/doris/pull/58922#discussion_r2630281307
##########
be/src/http/action/file_cache_action.cpp:
##########
@@ -161,6 +162,41 @@ Status FileCacheAction::_handle_header(HttpRequest* req,
std::string* json_metri
*json_metrics = json.ToString();
}
}
+ } else if (operation == RELOAD) {
+#ifdef BE_TEST
+ std::string doris_home = getenv("DORIS_HOME");
+ std::string conffile = std::string(doris_home) + "/conf/be.conf";
+ if (!doris::config::init(conffile.c_str(), true, true, true)) {
+ return Status::InternalError("Error reading config file");
+ }
+
+ std::string custom_conffile = doris::config::custom_config_dir +
"/be_custom.conf";
+ if (!doris::config::init(custom_conffile.c_str(), true, false, false))
{
+ return Status::InternalError("Error reading custom config file");
Review Comment:
be_custom.conf is optional
##########
be/src/io/tools/file_cache_microbench.cpp:
##########
@@ -835,10 +838,284 @@ struct Job {
}
};
Review Comment:
microbenchService can be removed as we only use file_cache_action api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
