eldenmoon commented on code in PR #59183:
URL: https://github.com/apache/doris/pull/59183#discussion_r2642218882


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/VariantType.java:
##########
@@ -51,13 +51,24 @@ public class VariantType extends PrimitiveType {
     private final List<VariantField> predefinedFields;
     private final int variantSparseHashShardCount;
 
-    // No predefined fields
+    private final boolean enableVariantDocSnapshotMode;
+    private final long variantDocSnapshotMinRows;
+    private final int variantDocSnapshotShardCount;
+
+    /**
+     * Creates a Variant type without predefined fields and only configures 
the max subcolumn limit.
+     *
+     * @param variantMaxSubcolumnsCount max number of subcolumns allowed (0 
means unlimited)
+     */
     public VariantType(int variantMaxSubcolumnsCount) {
         this.variantMaxSubcolumnsCount = variantMaxSubcolumnsCount;
         this.predefinedFields = Lists.newArrayList();
         this.enableTypedPathsToSparse = false;
         this.variantMaxSparseColumnStatisticsSize = 10000;
         this.variantSparseHashShardCount = 0;
+        this.enableVariantDocSnapshotMode = false;
+        this.variantDocSnapshotMinRows = 0L;
+        this.variantDocSnapshotShardCount = 128;

Review Comment:
   64?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to