morningman commented on code in PR #59056:
URL: https://github.com/apache/doris/pull/59056#discussion_r2644898086
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -359,8 +374,135 @@ public TableScan createTableScan() throws UserException {
}
private CloseableIterable<FileScanTask> planFileScanTask(TableScan scan) {
+ if (!IcebergUtils.isManifestCacheEnabled(source.getCatalog())) {
+ long targetSplitSize = getRealFileSplitSize(0);
+ return TableScanUtil.splitFiles(scan.planFiles(), targetSplitSize);
+ }
+ try {
+ return planFileScanTaskWithManifestCache(scan);
+ } catch (Exception e) {
+ LOG.warn("Plan with manifest cache failed, fallback to original
scan: {}", e.getMessage());
Review Comment:
better print the stack trace?
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -359,8 +374,135 @@ public TableScan createTableScan() throws UserException {
}
private CloseableIterable<FileScanTask> planFileScanTask(TableScan scan) {
+ if (!IcebergUtils.isManifestCacheEnabled(source.getCatalog())) {
+ long targetSplitSize = getRealFileSplitSize(0);
+ return TableScanUtil.splitFiles(scan.planFiles(), targetSplitSize);
+ }
+ try {
+ return planFileScanTaskWithManifestCache(scan);
+ } catch (Exception e) {
+ LOG.warn("Plan with manifest cache failed, fallback to original
scan: {}", e.getMessage());
Review Comment:
We need to add some metrics in explain or profile to check if the cache works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
