gavinchou commented on code in PR #59465:
URL: https://github.com/apache/doris/pull/59465#discussion_r2657078151
##########
be/src/common/config.cpp:
##########
@@ -2057,10 +2059,54 @@ Status set_config(const std::string& field, const
std::string& value, bool need_
"'{}' is type of '{}' which is not support to modify", field,
it->second.type);
}
+bool is_digits(const std::string& str) {
+ return !str.empty() && std::ranges::all_of(str, ::isdigit);
+}
+
+void update_get_rate_limiter(const std::string& field, const std::string&
value) {
Review Comment:
it is better to call the existing function in s3_util.cpp, there maybe too
<img width="885" height="140" alt="Image"
src="https://github.com/user-attachments/assets/126a7b73-4467-4d26-a146-09a7f5be2a53";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
