yiguolei commented on code in PR #59488:
URL: https://github.com/apache/doris/pull/59488#discussion_r2659271591
##########
be/src/olap/rowset/segment_v2/zone_map_index.cpp:
##########
@@ -58,7 +58,8 @@ void TypedZoneMapIndexWriter<Type>::add_values(const void*
values, size_t count)
if (count > 0) {
_page_zone_map.has_not_null = true;
}
- using ValType = PrimitiveTypeTraits<Type>::StorageFieldType;
+ using ValType = std::conditional_t<is_string_type(Type), StringRef,
Review Comment:
不要写这种condition，太散落了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
