eldenmoon commented on code in PR #59183:
URL: https://github.com/apache/doris/pull/59183#discussion_r2660196277


##########
be/src/olap/tablet_schema.h:
##########
@@ -213,36 +226,59 @@ class TabletColumn : public MetadataAdder<TabletColumn> {
 
     void set_frac(int frac) { _frac = frac; }
 
+    const VariantParams& variant_params() const { return _variant; }
+    VariantParams* mutable_variant_params() { return &_variant; }
+
+    int32_t variant_max_subcolumns_count() const { return 
_variant.max_subcolumns_count; }
+
     void set_variant_max_subcolumns_count(int32_t 
variant_max_subcolumns_count) {
-        _variant_max_subcolumns_count = variant_max_subcolumns_count;
+        _variant.max_subcolumns_count = variant_max_subcolumns_count;
     }
 
-    void set_variant_enable_typed_paths_to_sparse(bool enable) {
-        _variant_enable_typed_paths_to_sparse = enable;
+    PatternTypePB pattern_type() const { return _pattern_type; }
+
+    bool variant_enable_typed_paths_to_sparse() const {
+        return _variant.enable_typed_paths_to_sparse;
     }
 
-    void set_variant_max_sparse_column_statistics_size(
-            int32_t variant_max_sparse_column_statistics_size) {
-        _variant_max_sparse_column_statistics_size = 
variant_max_sparse_column_statistics_size;
+    int32_t variant_max_sparse_column_statistics_size() const {
+        return _variant.max_sparse_column_statistics_size;
     }
 
-    void set_variant_sparse_hash_shard_count(int32_t 
variant_sparse_hash_shard_count) {
-        _variant_sparse_hash_shard_count = variant_sparse_hash_shard_count;
+    int32_t variant_sparse_hash_shard_count() const { return 
_variant.sparse_hash_shard_count; }
+
+    bool variant_enable_doc_mode() const { return _variant.enable_doc_mode; }
+
+    int64_t variant_doc_materialization_min_rows() const {
+        return _variant.doc_materialization_min_rows;
     }
 
-    int32_t variant_max_subcolumns_count() const { return 
_variant_max_subcolumns_count; }
+    int32_t variant_doc_hash_shard_count() const { return 
_variant.doc_hash_shard_count; }
 
-    PatternTypePB pattern_type() const { return _pattern_type; }
+    void set_variant_doc_materialization_min_rows(int64_t 
variant_doc_materialization_min_rows) {

Review Comment:
   set逻辑可以传入一个TColumn



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to