yiguolei commented on code in PR #13865:
URL: https://github.com/apache/doris/pull/13865#discussion_r1017275927
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -268,11 +268,12 @@ Status SegmentIterator::_prepare_seek(const
StorageReadOptions::KeyRange& key_ra
for (auto cid : _seek_schema->column_ids()) {
int32_t unique_id = _opts.tablet_schema->column(cid).unique_id();
if (_column_iterators.count(unique_id) < 1) {
-
RETURN_IF_ERROR(_segment->new_column_iterator(_opts.tablet_schema->column(cid),
-
&_column_iterators[unique_id]));
+ RETURN_IF_ERROR(_segment->new_column_iterator(
+ _opts.tablet_schema->column(cid), _opts.io_ctx,
&_column_iterators[unique_id]));
ColumnIteratorOptions iter_opts;
iter_opts.stats = _opts.stats;
iter_opts.file_reader = _file_reader.get();
+ iter_opts.io_ctx = _opts.io_ctx;
RETURN_IF_ERROR(_column_iterators[unique_id]->init(iter_opts));
Review Comment:
column iterator's init method will get column iterator options and it
already contains io ctx, I think we could use it instead of modifying
new_column_iterator_method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
